[Mimedefang] Making an md5 key of the body

David F. Skoll dfs at roaringpenguin.com
Tue Mar 27 07:59:25 EST 2007


Danny Kjærgaard wrote:

>     chop($md5body=`md5 -q \"$bodypath\"`);

Aiieee!!!!!

If you see `this` in a production Perl script, it's probably wrong.
Use the Digest::MD5 Perl module instead and compute the MD5SUM of
INPUTMSG.

>     md_syslog('notice',"Md5body ($md5body $Subject [$#Recipients
> @Recipients])");

Use scalar(@Recipients) instead; read the perlintro(1) man page.

And your function belongs in filter_end, not filter -- read the
mimedefang-filter man page.

--
David.


More information about the MIMEDefang mailing list